Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated schema to enforce skill levels. #7

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Updated schema to enforce skill levels. #7

wants to merge 5 commits into from

Conversation

Schoonology
Copy link
Contributor

@Schoonology Schoonology commented Mar 9, 2018 •
edited
Loading

Side effects:

  • Minor updates to style.
  • Updated dependencies to latest.
  • Migrated from z-schema to ajv for validation.
  • Migrated from cson to cson-parser for CSON support.

agent-0028
agent-0028 reviewed Mar 12, 2018
View reviewed changes
Copy link
Contributor

@agent-0028 agent-0028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the housekeeping and upgrades!

data/schema-ext.json
"properties": {
"level": {
"type": "string",
"enum": ["Teaching others", "Pairing on", "Excited about"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned something about JSON schemas, very cool that they can be extended this way.

I like the intention behind this, making clear that we don't find much value in using "level" to rank our skills/languages etc. These specific categories don't resonate with me though, so I am glad for now that validation doesn't stop the build ;-) More specifically, they actually apply very well to all the skills I want to list on my resume, I am excited about and love to pair and teach (and learn) all of them!

I have some ideas I would like to mess with, but I'll express them in the form of a PR once I get some time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agent-0028 agent-0028 agent-0028 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schoonology @agent-0028